On 05/04/2026 19:23, Ashutosh Bapat wrote:
>> Both MultiXactShmemInit and MultiXactShmemAttach set
>> OldestMemberMXactId, OldestVisibleMXactId. In future if we add another
>> global variable to point to the shared memory, somebody needs to
>> remember to initialize it in both these functions. Maybe deduplicate
>> it with something like attached? Similarly for PredicateLock related
>> changes.
>
> Sorry, I attached the wrong patch. Here's the right patch.
Gotcha, yeah I've thought about that too. I even considered making
ShmemInitRequested() automatically call all the attach callbacks after
initialization, even in !EXEC_BACKEND builds. That way, you could put
the backend-private steps only in the attach function, and have
automatically be called in the postmaster too. I decided against it,
because only few subsystems need the attach callback at all, and many of
them need to do the "local" steps earlier in the init callback anyway.
For example, XLOGShmemInit() uses the WALInsertLocks variable inside the
function already.
In the end I decided it's OK as it is. I'm not too worried about the
duplicated code in multixact.c and predicate.c, they fit in the same
screen in an editor so it's pretty easy to see that they are duplicated
for a reason. With more complicated logic it would be a different story.
- Heikki
