On Thu, Jul 10, 2025 at 8:49 AM Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> On Wed, Jul 9, 2025 at 6:50 PM Ashutosh Bapat
> <ashutosh.bapat.oss@gmail.com> wrote:
> >
> > On Wed, Jul 9, 2025 at 8:30 AM shveta malik <shveta.malik@gmail.com> wrote:
> > > >
> > > > I have split your top up patch into 2 - one related to the document
> > > > change being the subject of this thread and the other for fixing the
> > > > query. Committer may squash the patch, if they think so.
> > > >
> > >
> > > The changes look good to me.
> >
> > Thanks.
> >
> > Looks like Amit has already committed it. I had created a CF entry
> > https://commitfest.postgresql.org/patch/5904/ to track this. I will
> > mark it as committed now.
> >
>
> Thanks.
>
> > Amit,
> > While reviewing the patches again, I felt that the second sentence in
> > that section also needs a bit of clarification. Here's patch with that
> > change. Please feel free to reject it or apply it.
> >
>
> The additional part: ""+ or when creating replication slots
> directly" you mentioned could be considered to be added. But I see
> that is already explained in the link mentioned in the doc, see [1].
> So, I suggest we leave this part of docs as it is.
>
> [1]:
https://www.postgresql.org/docs/current/logicaldecoding-explanation.html#LOGICALDECODING-REPLICATION-SLOTS-SYNCHRONIZATION
WFM.
--
Best Wishes,
Ashutosh Bapat
