Request a Demo
Home   >   mailing lists

Re: [PATCH] pgindent truncates last line of files missing a trailing newline - Mailing list pgsql-hackers

From Ashutosh Bapat
Subject Re: [PATCH] pgindent truncates last line of files missing a trailing newline
Date
Msg-id CAExHW5uSuG9qcGd=o6o6TiwWUKE4ie7K7nmgKzDzUKxrQ9rYDw@mail.gmail.com
Whole thread
In response to Re: [PATCH] pgindent truncates last line of files missing a trailing newline  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [PATCH] pgindent truncates last line of files missing a trailing newline
List pgsql-hackers
Tree view 
On Mon, Feb 16, 2026 at 10:20 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> Andrew Dunstan <andrew@dunslane.net> writes:
> > Yeah. I wonder if we shouldn't be just ensuring that there is a line
> > feed at the end of the buffer, i.e. add one if it's not there. We
> > shouldn't be adding files without a trailing LF, and ensuring there is
> > one seems like a reasonable thing to do in pg_bsd_indent.
>
> +1

+1. That will allow me to remove some code from my patch preparation
script. Ref. [1]

[1]
https://www.postgresql.org/message-id/flat/CAExHW5v8u7-2H2LqWP3ybhh5GnAVVeCOYuTfkg9pmdnrLwAtNA%40mail.gmail.com#fdbb87e825f89e7109dfb0ed959b2dd4

--
Best Wishes,
Ashutosh Bapat

pgsql-hackers by date:

Previous
From: "Hayato Kuroda (Fujitsu)"
Date:
Subject: RE: Improve docs syntax checking and enable it in the meson build
Next
From: Thomas Munro
Date:
Subject: Re: Questionable description about character sets