Request a Demo
Home   >   mailing lists

Re: [PATCH] pgindent truncates last line of files missing a trailing newline - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCH] pgindent truncates last line of files missing a trailing newline
Date
Msg-id 1133418.1771260634@sss.pgh.pa.us
Whole thread Raw
In response to Re: [PATCH] pgindent truncates last line of files missing a trailing newline  (Andrew Dunstan <andrew@dunslane.net>)
Responses Re: [PATCH] pgindent truncates last line of files missing a trailing newline
List pgsql-hackers
Tree view 
Andrew Dunstan <andrew@dunslane.net> writes:
> Yeah. I wonder if we shouldn't be just ensuring that there is a line 
> feed at the end of the buffer, i.e. add one if it's not there. We 
> shouldn't be adding files without a trailing LF, and ensuring there is 
> one seems like a reasonable thing to do in pg_bsd_indent.

+1

            regards, tom lane

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: index prefetching
Next
From: Noah Misch
Date:
Subject: Re: race condition in pg_class