Request a Demo
Home   >   mailing lists

Re: [PATCH] pgindent truncates last line of files missing a trailing newline - Mailing list pgsql-hackers

From Akshay Joshi
Subject Re: [PATCH] pgindent truncates last line of files missing a trailing newline
Date
Msg-id CANxoLDdbhQbap5vd3=01ad67EGbGNKDsvZdYVT3KRUiy-onYqA@mail.gmail.com
Whole thread
In response to Re: [PATCH] pgindent truncates last line of files missing a trailing newline  (Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>)
Responses Re: [PATCH] pgindent truncates last line of files missing a trailing newline
List pgsql-hackers
Tree view 
I have addressed the review comments from Andrew.
Attached is the v2 patch, ready for review.

On Tue, Feb 17, 2026 at 7:50 AM Ashutosh Bapat
<ashutosh.bapat.oss@gmail.com> wrote:
>
> On Mon, Feb 16, 2026 at 10:20 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> >
> > Andrew Dunstan <andrew@dunslane.net> writes:
> > > Yeah. I wonder if we shouldn't be just ensuring that there is a line
> > > feed at the end of the buffer, i.e. add one if it's not there. We
> > > shouldn't be adding files without a trailing LF, and ensuring there is
> > > one seems like a reasonable thing to do in pg_bsd_indent.
> >
> > +1
>
> +1. That will allow me to remove some code from my patch preparation
> script. Ref. [1]
>
> [1]
https://www.postgresql.org/message-id/flat/CAExHW5v8u7-2H2LqWP3ybhh5GnAVVeCOYuTfkg9pmdnrLwAtNA%40mail.gmail.com#fdbb87e825f89e7109dfb0ed959b2dd4
>
> --
> Best Wishes,
> Ashutosh Bapat
Attachment

pgsql-hackers by date:

Previous
From: Richard Guo
Date:
Subject: Re: Consider low startup cost in add_partial_path
Next
From: Zsolt Parragi
Date:
Subject: Re: Fix uninitialized xl_running_xacts padding