Re: PG_TEST_EXTRA and meson - Mailing list pgsql-hackers

From Ashutosh Bapat
Subject Re: PG_TEST_EXTRA and meson
Date
Msg-id CAExHW5tvqRh_fZnHjubS+NafR-L_-kQ_cNkoK77hbAn4Cnv-BQ@mail.gmail.com
Whole thread Raw
In response to Re: PG_TEST_EXTRA and meson  (Nazir Bilal Yavuz <byavuz81@gmail.com>)
Responses Re: PG_TEST_EXTRA and meson
List pgsql-hackers
On Tue, Jul 23, 2024 at 4:02 PM Nazir Bilal Yavuz <byavuz81@gmail.com> wrote:
>
> > I wonder whether we really require pg_test_extra argument to testwrap.
> > Why can't we use the logic in testwrap, to set run time PG_TEST_EXTRA,
> > in meson.build directly? I.e. set test_env['PG_TEST_EXTRA'] to
> > os.environ[;PG_TEST_EXTRA'] if the latter is set, otherwise set the
> > first to get_option('PG_TEST_EXTRA').
>
> When test_env('PG_TEST_EXTRA') is set, it could not be overridden
> afterwards. Perhaps there is a way to override test_env() but I do not
> know how.
>

I am not suggesting to override test_env['PG_TEST_EXTRA'] but set it
to the value after overriding if required. meson.build file seems to
allow some conditional variable setting. So I thought this would be
possible, haven't tried myself though.

--
Best Wishes,
Ashutosh Bapat



pgsql-hackers by date:

Previous
From: Nazir Bilal Yavuz
Date:
Subject: Re: PG_TEST_EXTRA and meson
Next
From: Andrew Dunstan
Date:
Subject: Re: xid_wraparound tests intermittent failure.