On Mon, Mar 24, 2025 at 5:40 PM Daniel Gustafsson <daniel@yesql.se> wrote:
>
> > With this patch, we are doing something unprecedented (at least
> > AFAIK); allowing command arguments defaults to be configurable through
> > a psql variable (as against an environment variable). I admit that
> > configurable through a psql variable is better since it doesn't meddle
> > with environment. Glancing through psql documentation, I didn't find a
> > lot of command which may need default argument to be configurable.
> > Nonetheless we should mention why this is special and set some
> > guidance for such future additions - preferrably in code or at least
> > in the commit message.
>
> Sure, I'll mention it in the commit message.
>
> > - of rows. Wait the specified number of seconds (default 2) between executions.
> > - For backwards compatibility,
> > + of rows. Wait the specified number of seconds (defaults to 2 if
> > omitted, which can be
> > + changed with the variable <xref linkend="app-psql-variables-watch-interval"/>)
> > + between executions. For backwards compatibility,
> >
> > The text in parenthesis is quite long and it's hard to read ...
> > seconds between execution. I suggest
> > "Wait the specified number of seconds (default 2) between executions.
> > The default wait can be changed by setting the variable <xref
> > linkend="app-psql-variables-watch-interval"/>."
>
> Fixed.
>
> > + " number of seconds \\watch waits between executing the query buffer\n");
> >
> > I am feeling that this should mention "default" somewhere - maybe just
> > add it before "number of ".
>
> Fixed.
LGTM. I think this is RFC. Updated CF entry.
--
Best Wishes,
Ashutosh Bapat
