Re: Small memory fixes for pg_createsubcriber - Mailing list pgsql-hackers

On Tue, Feb 25, 2025 at 08:54:31AM -0300, Ranier Vilela wrote:
> @@ -455,7 +455,9 @@ set_locale_and_encoding(void)
>   locale->db_locale,
>   strlen(locale->db_locale));
>   else
> - datlocale_literal = pg_strdup("NULL");
> + datlocale_literal = PQescapeLiteral(conn_new_template1,
> + "NULL",
> + strlen("NULL"));

Yeah, I've considered that but hardcoding NULL twice felt a bit weird,
as well.  Perhaps it's slightly cleaner to use an intermediate
variable given then as an argument of PQescapeLiteral()?