Re: missing warning in pg_import_system_collations - Mailing list pgsql-hackers

From Ranier Vilela
Subject Re: missing warning in pg_import_system_collations
Date
Msg-id CAEudQArVn++oaJbV=Drug4RxbfE7WZ0GzxS1poWbW5L8LxTT=Q@mail.gmail.com
Whole thread Raw
In response to missing warning in pg_import_system_collations  (Anton Voloshin <a.voloshin@postgrespro.ru>)
List pgsql-hackers
Em qui., 9 de set. de 2021 às 03:45, Anton Voloshin <a.voloshin@postgrespro.ru> escreveu:
Hello hackers,

In pg_import_system_collations() there is this fragment of code:

enc = pg_get_encoding_from_locale(localebuf, false);
if (enc < 0)
{
        /* error message printed by pg_get_encoding_from_locale() */
        continue;
}

However, false passed to pg_get_encoding_from_locale() means
write_message argument is false, so no error message is ever printed.
I propose an obvious patch (see attachment).
Yeah, seems correct to me.
The comment clearly expresses the intention.


Introduced in aa17c06fb in January 2017 when debug was replaced by
false, so I guess back-patching through 10 would be appropriate.
This is an oversight.

+1 from me.

Ranier Vilela

pgsql-hackers by date:

Previous
From: Amul Sul
Date:
Subject: TAP test for recovery_end_command
Next
From: Christoph Berg
Date:
Subject: trap instead of error on 32 TiB table