Re: Fix uninitialized variable access (src/backend/utils/mmgr/freepage.c) - Mailing list pgsql-hackers

From Ranier Vilela
Subject Re: Fix uninitialized variable access (src/backend/utils/mmgr/freepage.c)
Date
Msg-id CAEudQArMdeJjbaL5Vs5--3HhZF7qcg2OH0Ea-GnZ-HfLkXET3A@mail.gmail.com
Whole thread Raw
In response to Re: Fix uninitialized variable access (src/backend/utils/mmgr/freepage.c)  (Greg Nancarrow <gregn4422@gmail.com>)
List pgsql-hackers
Em ter., 17 de ago. de 2021 às 10:22, Greg Nancarrow <gregn4422@gmail.com> escreveu:
On Tue, Aug 17, 2021 at 9:13 PM Ranier Vilela <ranier.vf@gmail.com> wrote:
>
> If that's conditions happen, all *result.index* touches are garbage.
>

The patch looks valid to me, as the "index" member is not set in the
"btp == NULL" case, and so has a junk value in the caller, and it's
being used to index an array,
BUT - isn't it also necessary to set the "split_pages" member to 0,
because it also is not currently being set, and so too will have a
junk value in this case (and it's possible for it to be referenced by
the caller in this case).
I agree.

Attached new version (v1).

regards,
Ranier Vilela
Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: A problem in ExecModifyTable
Next
From: Peter Eisentraut
Date:
Subject: Re: automatically generating node support functions