Re: Improve cleaning files on Postgres crashes - Mailing list pgsql-hackers

From Ranier Vilela
Subject Re: Improve cleaning files on Postgres crashes
Date
Msg-id CAEudQArC5S6Sy4+Qs_87v3LpDd9ebwLB36zBwB+0r+TiO2hsvg@mail.gmail.com
Whole thread Raw
In response to Re: Improve cleaning files on Postgres crashes  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Improve cleaning files on Postgres crashes
List pgsql-hackers

Em ter., 18 de fev. de 2025 13:21, Tom Lane <tgl@sss.pgh.pa.us> escreveu:
Ranier Vilela <ranier.vf@gmail.com> writes:
> There are some reports that Postgres does not handle correctly cleaning the
> files used when it crashes. [1]
> I think that function *fcloseall* can help a little bit.
> Mainly on Windows.
Thanks for answear Tom.

I doubt that this is a good thing to try to do during a panic exit.
In the first place, we don't know to what extent the process's
internal data structures may be corrupted, possibly causing
fcloseall itself to malfunction. 
Well, I put after fflush(NULL), so if data structures are corrupted, fflush will fail in any way.

In the second place, we might
wish to have a look at those temp files for debugging purposes.
On dev/debug are great, but on production, where disk spaces cost money, I think that a good idea.

Maybe guarded by ifdefs?

Best regards,
Ranier Vilela 

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Clarification on Role Access Rights to Table Indexes
Next
From: Tom Lane
Date:
Subject: Re: Clarification on Role Access Rights to Table Indexes