Re: Avoid unecessary MemSet call (src/backend/utils/cache/relcache.c) - Mailing list pgsql-hackers

On 01.08.22 19:08, Ranier Vilela wrote:
> Like how
> https://github.com/postgres/postgres/commit/9fd45870c1436b477264c0c82eb195df52bc0919
> <https://github.com/postgres/postgres/commit/9fd45870c1436b477264c0c82eb195df52bc0919>
> New attempt to remove more MemSet calls, that are safe.
>
> Attached v3 patch.

Note that struct initialization does not set padding bits.

struct foo a = {  .i = 0,  .b = 0,
};

  So any
struct that is used as a hash key or that goes to disk or something
similar needs to be set with memset/MemSet instead.  Various places in
the code make explicit comments about that, which your patch deletes,
which is a mistake.  This patch needs to be adjusted carefully with this
in mind before it can be considered.