Postgres Pro
Downloads
Home   >   mailing lists

Re: Simplify the logic a bit (src/bin/scripts/reindexdb.c) - Mailing list pgsql-hackers

From Ranier Vilela
Subject Re: Simplify the logic a bit (src/bin/scripts/reindexdb.c)
Date
Msg-id CAEudQAr6OgJh2HfOvWki5jjDSaiPrz2=QB7cmOCw_sX3qUFg+A@mail.gmail.com
Whole thread Raw
In response to Re: Simplify the logic a bit (src/bin/scripts/reindexdb.c)  (Ranier Vilela <ranier.vf@gmail.com>)
List pgsql-hackers
Tree view
Em seg., 17 de mar. de 2025 às 16:17, Ranier Vilela <ranier.vf@gmail.com> escreveu:
Em sex., 7 de mar. de 2025 às 16:14, Ranier Vilela <ranier.vf@gmail.com> escreveu:


Em sex., 7 de mar. de 2025 às 16:01, Álvaro Herrera <alvherre@alvh.no-ip.org> escreveu:
On 2025-Mar-07, Álvaro Herrera wrote:

> Anyway, my version of this is attached.  It fixes the problems with your
> patch, but not Orlov's fundamental bug.

And of course I forgot to actually attach the patch.  Good grief.
Test with your v4 patch, on Windows 64 bits.
Rebased against 682c5be
Coverity reported two new warnings regarding reindexdb.

CID 1593911: (#1 of 1): Dereference after null check (FORWARD_NULL)
49. var_deref_op: Dereferencing null pointer indices_tables_cell. 

CID 1593910: (#1 of 1): Explicit null dereferenced (FORWARD_NULL)
9. var_deref_op: Dereferencing null pointer process_list. 

Attached is an attempt to fix.
 
best regards,
Ranier Vilela
Attachment

pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: dblink: Add SCRAM pass-through authentication
Next
From: Tom Lane
Date:
Subject: Re: Update Unicode data to Unicode 16.0.0