Home > mailing lists

[MASSMAIL] Fix some resources leaks (src/bin/pg_basebackup/pg_createsubscriber.c) - Mailing list pgsql-hackers

From	Ranier Vilela
Subject	[MASSMAIL] Fix some resources leaks (src/bin/pg_basebackup/pg_createsubscriber.c)
Date	March 28 02:50:09
Msg-id	CAEudQAr2_SZFxB4kXJiL4+2UaNZxUk5UBJtj0oXyJYMGZu-03g@mail.gmail.com Whole thread Raw
Responses	Re: Fix some resources leaks (src/bin/pg_basebackup/pg_createsubscriber.c)
List	pgsql-hackers

Hi,

Per Coverity.

Coverity has some reports in the new code

pg_createsubscriber.c

I think that Coverity is right.

CID 1542682: (#1 of 1): Resource leak (RESOURCE_LEAK)

leaked_storage: Variable buf going out of scope leaks the storage it points to.

CID 1542704: (#1 of 1): Resource leak (RESOURCE_LEAK)

leaked_storage: Variable conn going out of scope leaks the storage it points to.

CID 1542691: (#1 of 1): Resource leak (RESOURCE_LEAK)

leaked_storage: Variable str going out of scope leaks the storage it points to.

Patch attached.

best regards,

Ranier Vilela

From: Jelte Fennema-Nio
Date: 28 March, 02:47:46
Subject: Re: Possibility to disable `ALTER SYSTEM`

From: Bruce Momjian
Date: 28 March, 02:58:56
Subject: Re: Possibility to disable `ALTER SYSTEM`