> But the benchmark came from: > pgbench -i -p 5432 -d postgres > pgbench -c 50 -T 300 -S -n
I'm afraid this tells nothing unless you also provide the configuration files and the hardware description, and also some information on how you checked that there is no performance degradation on all the other supported platforms and possible configurations.
Benchmarking is a very complicated topic - trust me, been there!
Absolutely.
It would be better to submit two separate patches, the one that addresses Size_t and another that addresses shadowing. Refactorings only, nothing else.
Regarding the code formatting, please see src/tools/pgindent.
