Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] src\backend\utils\adt\numeric.c copy and past error - Mailing list pgsql-hackers

From Ranier Vilela
Subject Re: [PATCH] src\backend\utils\adt\numeric.c copy and past error
Date
Msg-id CAEudQAqYTg9h5E4zAWVC-tTKY=-4TsuXh=RP3zp5syY-nxTOUg@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] src\backend\utils\adt\numeric.c copy and past error  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [PATCH] src\backend\utils\adt\numeric.c copy and past error  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tree view
Hi,
Yes, but the comment it does not clarify that the return of the variable "const_one" is intentional, instead of "const_zero".
Anybody with reads the source, can think which is a copy and paste mistake.

regards
Ranier Vilela

Em dom., 19 de jan. de 2020 às 21:22, Tom Lane <tgl@sss.pgh.pa.us> escreveu:
Ranier Vilela <ranier.vf@gmail.com> writes:
> Possible copy and past error, found in numeric.c.
> I believe I believe that the author's intention was to return const_zero.

Did you read the comment just above there?

                        regards, tom lane

pgsql-hackers by date:

Previous
From: John Naylor
Date:
Subject: Re: remove separate postgres.(sh)description files
Next
From: Tom Lane
Date:
Subject: Re: range_agg