Postgres Pro
Downloads
Home   >   mailing lists

re: Why ALTER SUBSCRIPTION ... SET (slot_name='none') requires subscription disabled? - Mailing list pgsql-hackers

From Ranier Vilela
Subject re: Why ALTER SUBSCRIPTION ... SET (slot_name='none') requires subscription disabled?
Date
Msg-id CAEudQAqLtNJ1wvMKLK8ZH27SGJW5OjizgyMq28bFj-_5QG1G+A@mail.gmail.com
Whole thread Raw
In response to Why ALTER SUBSCRIPTION ... SET (slot_name='none') requires subscription disabled?  (Japin Li <japinli@hotmail.com>)
Responses Re: Why ALTER SUBSCRIPTION ... SET (slot_name='none') requires subscription disabled?  (Japin Li <japinli@hotmail.com>)
List pgsql-hackers
Tree view
>OTOH, when I execute ALTER SUBSCRIPTION ... SET (slot_name=''), it doesn't complain. However,
>SELECT select pg_create_logical_replication_slot('', 'pgoutput') complains slot name is too
>short. Although, the slot will be created at publisher, and validate the slot name, IMO, we
>can also validate the slot_name in parse_subscription_options() to get the error early.
>Attached fixes it. Any thoughts?
I think that this fix is better after the check if the name is equal to "none".
Most of the time it will be "none" .
While this, reduce the overhead with strlen into ReplicationSlotValidateName can it might be worth it.

For convenience, I have attached a new version.

regards,
Ranier Vilela
Attachment

pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: Pipeline mode and PQpipelineSync()
Next
From: Dean Rasheed
Date:
Subject: Re: Numeric x^y for negative x