Avoid is possible a expensive function call (src/backend/utils/adt/varlena.c) - Mailing list pgsql-hackers

From Ranier Vilela
Subject Avoid is possible a expensive function call (src/backend/utils/adt/varlena.c)
Date
Msg-id CAEudQAqL1x5GWXoRbHvAfqghNrVgVaeDX809p1X9p5RHchYfwA@mail.gmail.com
Whole thread Raw
Responses Re: Avoid is possible a expensive function call (src/backend/utils/adt/varlena.c)
List pgsql-hackers
Hi,

The function var_strcmp is a critical function.
Inside the function, there is a shortcut condition,
which allows for a quick exit.

Unfortunately, the current code calls a very expensive function beforehand, which if the test was true, all the call time is wasted.
So, IMO, it's better to postpone the function call until when it is actually necessary.

best regards,
Ranier Vilela
Attachment

pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: pgsql: Improve performance of subsystems on top of SLRU
Next
From: Matthias van de Meent
Date:
Subject: Re: Avoid is possible a expensive function call (src/backend/utils/adt/varlena.c)