Postgres Pro
Downloads
Home   >   mailing lists

Re: libpq support for NegotiateProtocolVersion - Mailing list pgsql-hackers

From Ranier Vilela
Subject Re: libpq support for NegotiateProtocolVersion
Date
Msg-id CAEudQAqG+nBgbdPfk9LxGMX5i6yxDKGNfpP6JQZHGF4fWEZ7+Q@mail.gmail.com
Whole thread Raw
In response to libpq support for NegotiateProtocolVersion  (Peter Eisentraut <peter.eisentraut@enterprisedb.com>)
Responses Re: libpq support for NegotiateProtocolVersion
List pgsql-hackers
Tree view
Hi.

Per Coverity.

CID 1596094: (#1 of 1): Structurally dead code (UNREACHABLE)
unreachable: Since the loop increment i++; is unreachable, the loop body will never execute more than once. 

The code of the function *pqGetNegotiateProtocolVersion3* is a little confusing.

I believe that the Coverity alert is valid.
The function never returns 0.

best regards,
Ranier Vilela

pgsql-hackers by date:

Previous
From: Tomas Vondra
Date:
Subject: Re: Draft for basic NUMA observability
Next
From: Shlok Kyal
Date:
Subject: Re: Proposal: Filter irrelevant change before reassemble transactions during logical decoding