Home > mailing lists

Fix memory leak when output postgres_fdw's "Relations" - Mailing list pgsql-hackers

From	Ranier Vilela
Subject	Fix memory leak when output postgres_fdw's "Relations"
Date	July 23, 2021 17:22:37
Msg-id	CAEudQAq6GgZuf3c_szDVXm08k-edb0SR7E+ATcs1WzGV=pHFVA@mail.gmail.com Whole thread Raw
Responses	Re: Fix memory leak when output postgres_fdw's "Relations" (Tom Lane <tgl@sss.pgh.pa.us>)
List	pgsql-hackers

Hi,

This is a minor leak, oversight in https://github.com/postgres/postgres/commit/4526951d564a7eed512b4a0ac3b5893e0a115690#diff-e399f5c029192320f310a79f18c20fb18c8e916fee993237f6f82f05dad851c5

ExplainPropertyText does not save the *relations->data* pointer and

var relations goes out of scope.

No need to backpatch.

regards,

Ranier Vilela

Attachment

fix_memory_leak_postgres_fdw.patch

pgsql-hackers by date:

Previous

From: Robert Haas
Date: 23 July 2021, 16:25:22
Subject: Re: [bug?] Missed parallel safety checks, and wrong parallel safety

Next

From: Mikhail Matrosov
Date: 23 July 2021, 17:27:36
Subject: Configure with thread sanitizer fails the thread test