Postgres Pro
Downloads
Home   >   mailing lists

Re: Signed vs Unsigned (take 2) (src/backend/storage/ipc/procarray.c) - Mailing list pgsql-hackers

From Ranier Vilela
Subject Re: Signed vs Unsigned (take 2) (src/backend/storage/ipc/procarray.c)
Date
Msg-id CAEudQAq5NQG-2J5ERyyx52z4GqYUPTdU8VtT083jz-7oj8bYdQ@mail.gmail.com
Whole thread Raw
In response to Re: Signed vs Unsigned (take 2) (src/backend/storage/ipc/procarray.c)  (Ranier Vilela <ranier.vf@gmail.com>)
Responses Re: Signed vs Unsigned (take 2) (src/backend/storage/ipc/procarray.c)  (Aleksander Alekseev <aleksander@timescale.com>)
List pgsql-hackers
Tree view
Em sex., 16 de jul. de 2021 às 09:41, Ranier Vilela <ranier.vf@gmail.com> escreveu:
Em sex., 16 de jul. de 2021 às 09:05, Aleksander Alekseev <aleksander@timescale.com> escreveu:
Hi Rainer,

> Here are the two patches.
> As suggested, reclassified as refactoring only.

Please don't change the status of the patch on CF application before
it was reviewed. It will only slow things down.
Hi Aleksander,
Sorry, lack of practice.


Your patch seems to have some problems on FreeBSD. Please see
http://commitfest.cputube.org/
I saw.
Very strange, in all other architectures, it went well.
I will have to install a FreeBSD to be able to debug.
There are a typo in 0001-Promove-unshadowing-of-two-variables-PGPROC-type.patch

- ProcArrayEndTransactionInternal(proc, proc->procArrayGroupMemberXid);
+ ProcArrayEndTransactionInternal(nextproc, nextproc->procArrayGroupMemberXid);

Attached new version v1, with fix.
Now pass check-world at FreeBSD 13 with clang 11.

regards,
Ranier Vilela
Attachment

pgsql-hackers by date:

Previous
From: Daniel Gustafsson
Date:
Subject: Re: OpenSSL 3.0.0 compatibility
Next
From: Bruce Momjian
Date:
Subject: Re: Have I found an interval arithmetic bug?