Re: plenty code is confused about function level static - Mailing list pgsql-hackers

From Ranier Vilela
Subject Re: plenty code is confused about function level static
Date
Msg-id CAEudQApyGcaywrbWVJsZxYOK+u2dVt4xHBy4YaPtwy6rqSH-VA@mail.gmail.com
Whole thread Raw
In response to Re: plenty code is confused about function level static  (Ranier Vilela <ranier.vf@gmail.com>)
List pgsql-hackers
Em qui., 18 de abr. de 2024 às 14:43, Ranier Vilela <ranier.vf@gmail.com> escreveu:


Em qui., 18 de abr. de 2024 às 14:16, Andres Freund <andres@anarazel.de> escreveu:
Hi,

On 2024-04-18 09:07:43 -0300, Ranier Vilela wrote:
>  On 18/04/2024 00:39, Andres Freund wrote:
> >There are lots of places that could benefit from adding 'static
> >const'.
>
> I found a few more places.

Good catches.


> Patch 004
>
> The opposite would also help, adding static.
> In these places, I believe it is safe to add static,
> allowing the compiler to transform into read-only, definitively.

I don't think this would even compile?
Compile, at least with msvc 2022.
Pass ninja test.


E.g. LockTagTypeNames, pg_wchar_table
are declared in a header and used across translation units.
Sad.
There should be a way to export a read-only (static const) variable.
Better remove these.

v1-0005 attached.
Now with v18 open, any plans to forward this?

best regards,
Ranier Vilela

pgsql-hackers by date:

Previous
From: Dean Rasheed
Date:
Subject: Re: Optimize numeric multiplication for one and two base-NBASE digit multiplicands.
Next
From: Alvaro Herrera
Date:
Subject: Re: LogwrtResult contended spinlock