Postgres Pro
Downloads
Home   >   mailing lists

Re: Eval expression R/O once time (src/backend/executor/execExpr.c) - Mailing list pgsql-hackers

From Ranier Vilela
Subject Re: Eval expression R/O once time (src/backend/executor/execExpr.c)
Date
Msg-id CAEudQApoeDkmXKSB2B6MjUtrcz9uMKvp2vAHx1+gvAgD0LYgng@mail.gmail.com
Whole thread Raw
In response to Re: Eval expression R/O once time (src/backend/executor/execExpr.c)  (Artur Zakirov <zaartur@gmail.com>)
Responses Re: Eval expression R/O once time (src/backend/executor/execExpr.c)  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tree view
Em sex., 1 de out. de 2021 às 06:55, Artur Zakirov <zaartur@gmail.com> escreveu:
On Wed, Sep 22, 2021 at 1:12 AM Ranier Vilela <ranier.vf@gmail.com> wrote:
> Anyway, the v1 patch fixes only the expression eval.

The patch looks good to me.

It seems that initially the code looked similar to your patch. See the
commit b8d7f053c5c2bf2a7e8734fe3327f6a8bc711755. Then the variables
were moved to foreach scope by the commit
1ec7679f1b67e84be688a311dce234eeaa1d5de8.
Thanks for the search.
It seems that 1ec7679f1b67e84be688a311dce234eeaa1d5de8 caused the problem.


I'll mark the patch as Ready for Commiter.
Thank you.

regards,
Ranier Vilela

pgsql-hackers by date:

Previous
From: Artur Zakirov
Date:
Subject: Re: Eval expression R/O once time (src/backend/executor/execExpr.c)
Next
From: Daniel Gustafsson
Date:
Subject: Re: Improve join selectivity estimation using extended statistics