Explicit NULL dereference (src/backend/commands/tablecmds.c) - Mailing list pgsql-hackers

From Ranier Vilela
Subject Explicit NULL dereference (src/backend/commands/tablecmds.c)
Date
Msg-id CAEudQApoJeWf8XKshcJjdnAPaV+SN0x_hHPoE9+xKLC7ifVFuQ@mail.gmail.com
Whole thread Raw
Responses Re: Explicit NULL dereference (src/backend/commands/tablecmds.c)
List pgsql-hackers
Hi,

Per Coverity.
CID 1453114 (#1 of 1): Explicit null dereferenced (FORWARD_NULL)
53. var_deref_model: Passing null pointer child_expr to strcmp, which dereferences it.

It is agreed that asserts should be used for error conditions that can never occur in the release.
But with errors that can occur, using assert does not make sense.

Better to make sure that strcmp can be called without risk.
Meanwhile, fix the strcmp call signature (const char).

#include <stdio.h>
#include <string.h>

int main()
{
    const char * s1="";
    const char * s2="0";
   
    if (strstr(s1, s2) != 0) {
        printf("found");
    } else {
        printf("not found");
    }
}
not found!

regards,
Ranier Vilela
Attachment

pgsql-hackers by date:

Previous
From: vignesh C
Date:
Subject: Re: subscriptioncheck failure
Next
From: Tom Lane
Date:
Subject: Re: Explicit NULL dereference (src/backend/commands/tablecmds.c)