Re: Non-text mode for pg_dumpall - Mailing list pgsql-hackers

From Ranier Vilela
Subject Re: Non-text mode for pg_dumpall
Date
Msg-id CAEudQApnevrfG=GM5YZOfrHm4PmK+oXmz+eA=3Pv8tC2oZRoPg@mail.gmail.com
Whole thread Raw
In response to Re: Non-text mode for pg_dumpall  (Andrew Dunstan <andrew@dunslane.net>)
Responses Re: Non-text mode for pg_dumpall
List pgsql-hackers


Em qui., 10 de abr. de 2025 20:09, Andrew Dunstan <andrew@dunslane.net> escreveu:


On 2025-04-10 Th 5:45 PM, Ranier Vilela wrote:

Em qui., 10 de abr. de 2025 às 15:58, Andrew Dunstan <andrew@dunslane.net> escreveu:


On 2025-04-10 Th 2:38 PM, Ranier Vilela wrote:


Thanks. I have pushed these now with a few further small tweaks.

Sorry if it is not the right place.
Coverity has another resource leak alert.

trivial patch attached.




Thanks for checking. Pushed.

Andew, I think that the commit wasn't very correct.
Now the variable *q* is being destroyed inside the loop.

The patch was destroying the variable *q* (stringinfo),
after the loop while.
 


Yes, you're right. Must be blind. Fixed.

Thanks Andrew.

best regards,
Ranier Vilela

pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: Non-text mode for pg_dumpall
Next
From: Sami Imseih
Date:
Subject: Re: stats.sql fails during installcheck on mac