[MASSMAIL] Fix possible dereference null pointer (src/backend/replication/logical/reorderbuffer.c) - Mailing list pgsql-hackers

From Ranier Vilela
Subject [MASSMAIL] Fix possible dereference null pointer (src/backend/replication/logical/reorderbuffer.c)
Date
Msg-id CAEudQApm0Kffq4GKLdyogyW1tVbkHOOqWTWg169OTsm1W=FUHg@mail.gmail.com
Whole thread Raw
Responses Re: Fix possible dereference null pointer (src/backend/replication/logical/reorderbuffer.c)
List pgsql-hackers
Hi,

Per Coverity.

The function ReorderBufferTXNByXid,
can return NULL when the parameter *create* is false.

In the functions ReorderBufferSetBaseSnapshot
and ReorderBufferXidHasBaseSnapshot,
the second call to ReorderBufferTXNByXid,
pass false to *create* argument.

In the function ReorderBufferSetBaseSnapshot,
fixed passing true as argument to always return
a valid ReorderBufferTXN pointer.

In the function ReorderBufferXidHasBaseSnapshot,
fixed by checking if the pointer is NULL.

best regards,
Ranier Vilela
Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: psql: Greatly speed up "\d tablename" when not using regexes
Next
From: Peter Geoghegan
Date:
Subject: Re: Table AM Interface Enhancements