Em sex., 16 de jul. de 2021 às 07:05, David Rowley <dgrowleyml@gmail.com> escreveu:
On Fri, 16 Jul 2021 at 20:35, Japin Li <japinli@hotmail.com> wrote: > > When I fix a bug about ALTER SUBSCRIPTION ... SET (slot_name) [1], Ranier Vilela > > finds that ReplicationSlotValidateName() has redundant strlen() call, Since it's > > not related to that problem, so I start a new thread to discuss it.
I think this is a waste of time. The first strlen() call is just checking for an empty string. I imagine all compilers would just optimise that to checking if the first char is '\0';
I think with very simple functions, the compiler can do the job.
