Re: [PATCH] Fix ouside scope t_ctid (ItemPointerData) - Mailing list pgsql-hackers

From Ranier Vilela
Subject Re: [PATCH] Fix ouside scope t_ctid (ItemPointerData)
Date
Msg-id CAEudQApNke-0_0CU34Stzd1sZ5Kn9iLNxP8yVBZMXiVMmLnU-A@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Fix ouside scope t_ctid (ItemPointerData)  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Em qui., 14 de mai. de 2020 às 15:07, Tom Lane <tgl@sss.pgh.pa.us> escreveu:
Ranier Vilela <ranier.vf@gmail.com> writes:
> The patch is primarily intended to correct the use of ItemPointerData.

What do you think is being "corrected" here?  It looks to me like
just some random code rearrangements that aren't even clearly
bug-free, let alone being stylistic improvements.
It is certainly working, but trusting that the memory of a local variable will not change,
when it loses its scope, is a risk that, certainly, can cause bugs, elsewhere.
And it is certainly very difficult to discover its primary cause.
 
regards,
Ranier Vilela

pgsql-hackers by date:

Previous
From: Ranier Vilela
Date:
Subject: Re: [PATCH] Fix ouside scope t_ctid (ItemPointerData)
Next
From: Robert Haas
Date:
Subject: Re: new heapcheck contrib module