Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] Fix out-of-bouds access (src/common/wchar.c) - Mailing list pgsql-hackers

From Ranier Vilela
Subject Re: [PATCH] Fix out-of-bouds access (src/common/wchar.c)
Date
Msg-id CAEudQApN1JKWtNo5SEPg-hdi=q9H+iLSqhBXgQX+HGu=sUoJAg@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Fix out-of-bouds access (src/common/wchar.c)  (Daniel Gustafsson <daniel@yesql.se>)
Responses Re: [PATCH] Fix out-of-bouds access (src/common/wchar.c)  (Daniel Gustafsson <daniel@yesql.se>)
List pgsql-hackers
Tree view
Em qui., 17 de fev. de 2022 às 09:52, Daniel Gustafsson <daniel@yesql.se> escreveu:
> On 17 Feb 2022, at 13:19, Ranier Vilela <ranier.vf@gmail.com> wrote:

> 1. One #ifdef with a mistake, the correct is _WIN32 and not WIN32.

Can you elaborate on this, we are using WIN32 pretty extensively in the code:

 $ git grep "if[n]\{0,1\}def WIN32$"|wc -l
     511
 $ git grep "if[n]\{0,1\}def _WIN32$"|wc -l
       2

The _WIN32 cases are in the same ECPG testcase.

Why would _WIN32 be correct in this case?
Sorry, my fault.

I only use _WIN32 and I jumped to conclusions very quickly.

regards,
Ranier Vilela

pgsql-hackers by date:

Previous
From: Daniel Gustafsson
Date:
Subject: Re: [PATCH] Fix out-of-bouds access (src/common/wchar.c)
Next
From: Daniel Gustafsson
Date:
Subject: Re: [PATCH] Fix out-of-bouds access (src/common/wchar.c)