> I think that commit 61461a3, left some oversight. > The function *PQcancelCreate* fails in check, > return of *calloc* function. > > Trivial fix is attached.
Agreed, this looks like a copy/paste from the calloc calls a few lines up.
Yeah.
> But, IMO, I think that has more problems. > If any allocation fails, all allocations must be cleared. > Or is the current behavior acceptable?
Since this is frontend library code I think we should free all the allocations in case of OOM.
