On 18.05.22 15:52, Peter Eisentraut wrote: > On 18.05.22 01:18, Justin Pryzby wrote: >> Take the first one as an example. It says: >> >> GenericCosts costs; >> MemSet(&costs, 0, sizeof(costs)); >> >> You sent a patch to change it to sizeof(GenericCosts). >> >> But it's not a pointer, so they are the same. > > This instance can more easily be written as > > costs = {0};
The attached patch replaces all MemSet() calls with struct initialization where that is easily possible. (For example, some cases have to worry about padding bits, so I left those.)