On 18.05.22 01:18, Justin Pryzby wrote: > Take the first one as an example. It says: > > GenericCosts costs; > MemSet(&costs, 0, sizeof(costs)); > > You sent a patch to change it to sizeof(GenericCosts). > > But it's not a pointer, so they are the same.
This instance can more easily be written as
costs = {0};
That would initialize the content at compilation and not at runtime, correct?
And we would avoid MemSet/memset altogether.
There are a lot of cases using MemSet (with struct variables) and at Windows 64 bits, long are 4 (four) bytes.
So I believe that MemSet is less efficient on Windows than on Linux.
"The size of the '_vstart' buffer is not a multiple of the element size of the type 'long'."
