Postgres Pro
Downloads
Home   >   mailing lists

Re: Avoid redudant initialization and possible memory leak (src/backend/parser/parse_relation.c) - Mailing list pgsql-hackers

From Ranier Vilela
Subject Re: Avoid redudant initialization and possible memory leak (src/backend/parser/parse_relation.c)
Date
Msg-id CAEudQAo0h2Xm-z7h1Bd-+QPM3X6ahZvpwnf7pEs0haasAcUr+Q@mail.gmail.com
Whole thread Raw
In response to Re: Avoid redudant initialization and possible memory leak (src/backend/parser/parse_relation.c)  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
Responses Re: Avoid redudant initialization and possible memory leak (src/backend/parser/parse_relation.c)
List pgsql-hackers
Tree view
Em ter., 13 de set. de 2022 às 11:09, Alvaro Herrera <alvherre@alvh.no-ip.org> escreveu:
On 2022-Sep-13, Ranier Vilela wrote:

> However, for Postgres 15 this may can cause a small memory leak.

What memory leak?  There's no leak here.
Yeah, as per Julien's answer, there is really no memory leak, but just unnecessary double execution of pstrdup.
But for Postgres 15, I believe it's worth avoiding this, because it's wasted cycles.
For Postgres 16, I believe this will be fixed as well, but for robustness, better fix soon, IMO.

regards,
Ranier Vilela

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Can we avoid chdir'ing in resolve_symlinks() ?
Next
From: "Jonathan S. Katz"
Date:
Subject: Re: First draft of the PG 15 release notes