Re: Move pg_attribute.attcompression to earlier in struct for reduced size? - Mailing list pgsql-hackers

From Ranier Vilela
Subject Re: Move pg_attribute.attcompression to earlier in struct for reduced size?
Date
Msg-id CAEudQAo-GAT_u4rbb=TULSUwpuVq9oJ4ZbfMax7L+_=k4FU3xw@mail.gmail.com
Whole thread Raw
In response to Move pg_attribute.attcompression to earlier in struct for reduced size?  (Andres Freund <andres@anarazel.de>)
Responses Re: Move pg_attribute.attcompression to earlier in struct for reduced size?
List pgsql-hackers

> Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:

> > Now, while this patch does seem to work correctly, it raises a number of
> > weird cpluspluscheck warnings, which I think are attributable to the
> > new macro definitions. I didn't look into it closely, but I suppose it
> > should be fixable given sufficient effort:
>
> Didn't test, but the first one is certainly fixable by adding a cast,
> and I guess the others might be as well.

>I get no warnings with this one. I'm a bit wary of leaving
>VARDATA_COMPRESSED_GET_EXTSIZE unchanged, but at least nothing in this
>patch requires a cast there.

Hi Alvaro.

Please, would you mind testing with these changes.
I'm curious to see if anything improves or not.
1. Add a const to the attr parameter.
2. Remove the cmid variable (and store it).
3. Add tail cut.

regards,

Ranier Vilela

Attachment

pgsql-hackers by date:

Previous
From: vignesh C
Date:
Subject: Re: Added schema level support for publication.
Next
From: Fabien COELHO
Date:
Subject: Re: Failures with gcd functions with GCC snapshots GCC and -O3 (?)