On Wed, Nov 23, 2016 at 2:28 PM, Robert Haas <robertmhaas@gmail.com> wrote:
> The code here looks OK. A few thoughts:
>
> - I'm a little unsure whether it's a good idea to remove the existing
> barrier.h and immediately add a new barrier.h that does something
> totally different. It's tempting to try to find another name for
> these things just to avoid that. Then again, I bet there's not much
> non-core code that is relying on the existing barrier.h, so maybe it's
> OK. On the third hand, the risk of confusing developers may be
> non-nil even if we don't confuse any code. I think I'll go commit
> remove-useless-barrier-v4.patch now and see if anyone shows up to
> complain...
Here is a new version with updated copyright messages and some dtrace
probes which provide an easy way to measure the time spend waiting at
barriers.
--
Thomas Munro
http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
