Re: pg_config.h.win32 missing a set of flags from pg_config.h.inadded in v11 development - Mailing list pgsql-hackers

From Thomas Munro
Subject Re: pg_config.h.win32 missing a set of flags from pg_config.h.inadded in v11 development
Date
Msg-id CAEepm=2zw7u_HUZY0RgVE7oYA8-NQKaqcVj+WyFYskcq_QZcUQ@mail.gmail.com
Whole thread Raw
In response to Re: pg_config.h.win32 missing a set of flags from pg_config.h.inadded in v11 development  (Michael Paquier <michael@paquier.xyz>)
Responses Re: pg_config.h.win32 missing a set of flags from pg_config.h.inadded in v11 development
List pgsql-hackers
On Wed, Jun 13, 2018 at 2:06 PM, Michael Paquier <michael@paquier.xyz> wrote:
> HAVE_LDAP_INITIALIZE is added in the list, but this is disabled as I
> could not test it.  It could always be possible to revisit that later.
> Thomas, what do you think?

It should be disabled on Windows, as you have it.

ldap_initialize() is a non-standard extension that provides a way to
use "ldaps" with OpenLDAP, but we don't even support using OpenLDAP on
Windows.  We know how to use Win32's non-standard extension
ldap_sslinit() instead if WIN32 is defined.

The reason we have a configure test is because ancient OpenLDAP as
shipped with ancient macOS and RHEL5 (present in our build farm) don't
have the function, and commercial LDAP API implementations that ship
with big iron Unices probably don't have it either.  It's not in
"ldapext-ldap-c-api-05.txt", which seems to be the last known version
of the eternally drafty standard.  Effectively, we'll fall back to
ldap_init() and disallow "ldaps" unless you have a fairly recent
OpenLDAP or Windows (I suspect that covers > 99% of users).

-- 
Thomas Munro
http://www.enterprisedb.com


pgsql-hackers by date:

Previous
From: Amit Langote
Date:
Subject: Re: Needless additional partition check in INSERT?
Next
From: Michael Paquier
Date:
Subject: Re: pg_config.h.win32 missing a set of flags from pg_config.h.inadded in v11 development