Re: [COMMITTERS] pgsql: Add support for coordinating record typmodsamong parallel worke - Mailing list pgsql-committers

From Thomas Munro
Subject Re: [COMMITTERS] pgsql: Add support for coordinating record typmodsamong parallel worke
Date
Msg-id CAEepm=2q2OoJ5K1Mg2_XaqjSSRbMTAmE4V7fsM5O3yTWWkb2aw@mail.gmail.com
Whole thread Raw
In response to Re: [COMMITTERS] pgsql: Add support for coordinating record typmodsamong parallel worke  (Thomas Munro <thomas.munro@enterprisedb.com>)
Responses Re: [COMMITTERS] pgsql: Add support for coordinating record typmods among parallel worke  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
On Fri, Sep 15, 2017 at 4:34 PM, Thomas Munro
<thomas.munro@enterprisedb.com> wrote:
> Here's a version that just forward declares SharedRecordTypmodRegistry
> in session.h (but keeps the typedef in typcache.h where it is useful
> for shorter function prototypes).  Neither GCC 6 -Wall -std=c89 not
> Clang -Wall -std=c89 complained about this problem.  I found an old
> GCC 4.3 compiler and it complained about the typedef redefinition and
> also the use of an anonymous union, also fixed in the attached.  Sorry
> about that -- clearly I need to test my patches on more compilers in
> future.

Rebased on your fix.  Investigating the runtime failure...

-- 
Thomas Munro
http://www.enterprisedb.com

-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

Attachment

pgsql-committers by date:

Previous
From: Thomas Munro
Date:
Subject: Re: [COMMITTERS] pgsql: Add support for coordinating record typmodsamong parallel worke
Next
From: Tom Lane
Date:
Subject: Re: [COMMITTERS] pgsql: Add support for coordinating record typmods among parallel worke