Re: [COMMITTERS] pgsql: Fix bogus size calculation introduced bycommit cc5f81366. - Mailing list pgsql-committers

From Thomas Munro
Subject Re: [COMMITTERS] pgsql: Fix bogus size calculation introduced bycommit cc5f81366.
Date
Msg-id CAEepm=2W_1c1tY65ZWc-sPF1Ma-YruQTov+UmmDDOgRZkhRRDw@mail.gmail.com
Whole thread Raw
In response to [COMMITTERS] pgsql: Fix bogus size calculation introduced by commit cc5f81366.  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [COMMITTERS] pgsql: Fix bogus size calculation introduced bycommit cc5f81366.  (Michael Paquier <michael.paquier@gmail.com>)
List pgsql-committers
On Mon, Sep 18, 2017 at 3:35 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Fix bogus size calculation introduced by commit cc5f81366.
>
> The elements of RecordCacheArray are TupleDesc, not TupleDesc *.
> Those are actually the same size, so that this error is harmless,
> but it's still wrong --- and it might bite us someday, if TupleDesc
> ever became a struct, say.
>
> Per Coverity.

Thanks.

While googling around trying to find where I could read Coverity's
output myself I was intrigued to see that https://scan.coverity.com
offers integration with Travis CI[1], which suggests the possibility
of automatically scanning all Commitfest submissions.  The trouble is
that for projects over 1 million lines of code they limit scans to one
per day, so it'd take over 200 days to get through the current
Commitfest, assuming no one ever posted new versions or committed
anything in the meantime.  Hah.  I guess Coverity analysis is going to
have to remain post-commit only.

[1] https://scan.coverity.com/travis_ci

-- 
Thomas Munro
http://www.enterprisedb.com


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: [COMMITTERS] pgsql: Doc: update v10 release notes through today.
Next
From: Peter Geoghegan
Date:
Subject: Re: [COMMITTERS] pgsql: Fix transient mdsync() errors of truncatedrelations due to 72a9