Re: [HACKERS] Parallel Append implementation - Mailing list pgsql-hackers

From Thomas Munro
Subject Re: [HACKERS] Parallel Append implementation
Date
Msg-id CAEepm=1o8SQysgbLxgShVXN9hZ9tQGWJi9-HvuwvkbzzdvN5yg@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] Parallel Append implementation  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: [HACKERS] Parallel Append implementation
List pgsql-hackers
On Thu, May 10, 2018 at 7:08 AM, Robert Haas <robertmhaas@gmail.com> wrote:
>  [parallel-append-doc-v2.patch]

+    plans just as they can in any other plan.  However, in a parallel plan,
+    it is also possible that the planner may choose to substitute a
+    <literal>Parallel Append</literal> node.

Maybe drop "it is also possible that "?  It seems a bit unnecessary
and sounds a bit odd followed by "may <verb>", but maybe it's just me.

+    Also, unlike a regular <literal>Append</literal> node, which can only have
+    partial children when used within a parallel plan, <literal>Parallel
+    Append</literal> node can have both partial and non-partial child plans.

Missing "a" before "<literal>Parallel".

+    Non-partial children will be scanned by only a single worker, since

Are we using "worker" in a more general sense that possibly includes
the leader?  Hmm, yes, other text on this page does that too.  Ho hum.

-- 
Thomas Munro
http://www.enterprisedb.com


pgsql-hackers by date:

Previous
From: Tomas Vondra
Date:
Subject: Re: Bizarre behavior in libpq's searching of ~/.pgpass
Next
From: "Bossart, Nathan"
Date:
Subject: Re: Add SKIP LOCKED to VACUUM and ANALYZE