On Sat, Jan 6, 2018 at 6:33 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> As I feared, the existing regression tests are not really adequate for
> this: gcov testing shows that the sentinel-inserting code path is
> never entered, meaning ConditionVariableBroadcast never sees more
> than one waiter. What's more, it's now also apparent that no outside
> caller of ConditionVariableSignal ever actually awakens anything.
> So I think it'd be a good idea to expand the regression tests if we
> can do so cheaply. Anybody have ideas about that? Perhaps a new
> module under src/test/modules would be the best way? Alternatively,
> we could drop some of the optimization ideas.
I think I might have a suitable test module already. I'll tidy it up
and propose it in a few days.
> BTW, at least on gaur, this does nothing for the runtime of the join
> test, meaning I'd still like to see some effort put into reducing that.
Will do.
--
Thomas Munro
http://www.enterprisedb.com
