Re: [HACKERS] WIP: [[Parallel] Shared] Hash - Mailing list pgsql-hackers

From Thomas Munro
Subject Re: [HACKERS] WIP: [[Parallel] Shared] Hash
Date
Msg-id CAEepm=1OuKD1dPw_CRapPf5PQnUW3v2EdNf0bXmx6BzCFCMRow@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] WIP: [[Parallel] Shared] Hash  (Peter Geoghegan <pg@heroku.com>)
Responses Re: [HACKERS] WIP: [[Parallel] Shared] Hash  (Thomas Munro <thomas.munro@enterprisedb.com>)
List pgsql-hackers
On Mon, Jan 2, 2017 at 3:17 PM, Peter Geoghegan <pg@heroku.com> wrote:
> I noticed a bug in your latest revision:
>
>> +   /*
>> +    * In HJ_NEED_NEW_OUTER, we already selected the current inner batch for
>> +    * reading from.  If there is a shared hash table, we may have already
>> +    * partially loaded the hash table in ExecHashJoinPreloadNextBatch.
>> +    */
>> +   Assert(hashtable->batch_reader.batchno = curbatch);
>> +   Assert(hashtable->batch_reader.inner);
>
> Obviously this isn't supposed to be an assignment.

Right, thanks!  I will post a new rebased version soon with that and
some other nearby problems fixed.

-- 
Thomas Munro
http://www.enterprisedb.com



pgsql-hackers by date:

Previous
From: Craig Ringer
Date:
Subject: Re: [HACKERS] Logical decoding - filtering tables
Next
From: Rajkumar Raghuwanshi
Date:
Subject: Re: [HACKERS] Declarative partitioning - another take