Re: [HACKERS] Log LDAP "diagnostic messages"? - Mailing list pgsql-hackers

From Thomas Munro
Subject Re: [HACKERS] Log LDAP "diagnostic messages"?
Date
Msg-id CAEepm=0quy9uCyhuV8fS2mPzca88yiv=pg8FbQPxFfW7Bu2QAA@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] Log LDAP "diagnostic messages"?  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
List pgsql-hackers
On Fri, Oct 13, 2017 at 3:59 PM, Peter Eisentraut
<peter.eisentraut@2ndquadrant.com> wrote:
> On 9/24/17 07:00, Thomas Munro wrote:
>> Fair point.  In that case there are a few others we should consider
>> moving down too for consistency, like in the attached.
>
>> Thanks, that is much tidier.  Done that way in the attached.
>>
>> Here also is a small addition to your TAP test which exercises the
>> non-NULL code path because slapd rejects TLS by default with a
>> diagnostic message.  I'm not sure if this is worth adding, since it
>> doesn't actually verify that the code path is reached (though you can
>> see that it is from the logs).
>
> Committed.

Thanks, and thanks also for follow-up commit 7d1b8e75.  Looks like the
new macro arrived in OpenLDAP 2.4 but RHEL5 shipped with 2.3.

-- 
Thomas Munro
http://www.enterprisedb.com


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [HACKERS] oversight in EphemeralNamedRelation support
Next
From: Michael Paquier
Date:
Subject: Re: [HACKERS] BLK_DONE state in XLogReadBufferForRedoExtended