Re: Valgrind failures in Apply Launcher's bgworker_quickdie() exit - Mailing list pgsql-hackers

From Thomas Munro
Subject Re: Valgrind failures in Apply Launcher's bgworker_quickdie() exit
Date
Msg-id CAEepm=0aPt-us2=iTL8tETwG_s46HFjZu-kjfJ7Zv4Fn19XuJA@mail.gmail.com
Whole thread Raw
In response to Re: Valgrind failures in Apply Launcher's bgworker_quickdie() exit  (Andres Freund <andres@anarazel.de>)
Responses Re: Valgrind failures in Apply Launcher's bgworker_quickdie() exit
List pgsql-hackers
On Mon, Dec 17, 2018 at 7:57 AM Andres Freund <andres@anarazel.de> wrote:
> The interesting bit is that if I replace the _exit(2) in
> bgworker_quickdie() with an exit(2) (i.e. processing atexit handlers),
> or manully add an OPENSSL_cleanup() before the _exit(2), valgrind
> doesn't find errors.

Weird.  Well I can see that there were bugs last year where OpenSSL
failed to clean up its thread locals[1], and after they fixed that,
cases where it bogusly cleaned up someone else's thread locals[2].
Maybe there is some interference between pthread keys or something
like that.

[1] https://github.com/openssl/openssl/issues/3033
[2] https://github.com/openssl/openssl/issues/3584


-- 
Thomas Munro
http://www.enterprisedb.com


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Improving collation-dependent indexes in system catalogs
Next
From: Erik Rijkers
Date:
Subject: Re: select limit error in file_fdw