Re: COPY command with RLS bug - Mailing list pgsql-hackers

From Adam Brightwell
Subject Re: COPY command with RLS bug
Date
Msg-id CAE_9P=gBxY5trCJxQnZ-fOrF4t4pOuAVWpjRM7ECZenX2r_OJQ@mail.gmail.com
Whole thread Raw
In response to Re: COPY command with RLS bug  (Simon Riggs <simon@2ndquadrant.com>)
Responses Re: COPY command with RLS bug  (Michael Paquier <michael.paquier@gmail.com>)
List pgsql-hackers
> Thanks for the report and the fix.

Yup. I have added it to the 2016-11 commitfest:
https://commitfest.postgresql.org/11/794/

> This seems a rather basic error to occur a year after release.
>
> Is this a problem with the testing of RLS? What other RLS related
> failures exist in other commands?

I think was simply due to a small gap in the test suite.

> Perhaps we should extend rowsecurity test with a more comprehensive
> set of tests rather than just fix the COPY one?

I think more tests that provide value are always a *good* thing,
however, would argue that other tests 'unrelated' to this fix are more
of a TODO item than something to include with this fix. Though, I am
certainly willing to attempt to find/add more test cases around this
specific functionality if that is desired.

-Adam



pgsql-hackers by date:

Previous
From: Greg Stark
Date:
Subject: Re: GiST penalty functions [PoC]
Next
From: Peter Eisentraut
Date:
Subject: Re: Relax requirement for INTO with SELECT in pl/pgsql