Re: Improving and extending int128.h to more of numeric.c - Mailing list pgsql-hackers

From Dean Rasheed
Subject Re: Improving and extending int128.h to more of numeric.c
Date
Msg-id CAEZATCXnRaQG7xwm=_4+T3ZhMxb30ispKu8k8nmCQa++mD6Ofg@mail.gmail.com
Whole thread Raw
In response to Re: Improving and extending int128.h to more of numeric.c  (Dean Rasheed <dean.a.rasheed@gmail.com>)
List pgsql-hackers
On Wed, 16 Jul 2025 at 19:23, Dean Rasheed <dean.a.rasheed@gmail.com> wrote:
>
> On 64-bit Linux with gcc 14.2 and native int128 support disabled I got
> the following results:
>
> Query 1:
>   HEAD:  1404.096 ms
>   Patch:  992.818 ms
>
> Query 2:
>   HEAD:  1498.949 ms
>   Patch:  935.654 ms
>

BTW, my other motivation for doing this was to simplify the numeric
code. Even if this had zero performance benefit, as long as it didn't
make things any slower, I would argue that it's worth doing.

The other 2 places in numeric.c that have conditional 128-bit integer
code would require more complex hand-written code to replace, such as
128-bit-by-128-bit division. That's obviously doable, but perhaps not
worth the effort as long as it's only those 2 numeric functions that
need it. OTOH, if there's a wider demand for 128-bit integers, that
might change.

Regards,
Dean



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Missing NULL check after calling ecpg_strdup
Next
From: "Joel Jacobson"
Date:
Subject: Re: Optimize LISTEN/NOTIFY