Postgres Pro
Downloads
Home   >   mailing lists

Re: psql :: support for \ev viewname and \sv viewname - Mailing list pgsql-hackers

From Dean Rasheed
Subject Re: psql :: support for \ev viewname and \sv viewname
Date
Msg-id CAEZATCW9EAv2X0iVaVRuUWRs4KjA=Pm+pdni99_p1dS-kqmEnA@mail.gmail.com
Whole thread Raw
In response to Re: psql :: support for \ev viewname and \sv viewname  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
List pgsql-hackers
Tree view 
On 4 May 2016 at 13:23, Peter Eisentraut
<peter.eisentraut@2ndquadrant.com> wrote:
> On 5/4/16 3:21 AM, Dean Rasheed wrote:
>> Well, appendStringLiteralAH() takes both, so that sets a precedent.
> Works for me.  Could you supply an updated patch with a static function
> instead of a macro?  Then I think this is good to go.
>
> (bonus points for some tests)
>

OK, pushed that way.

I didn't get round to adding any tests though. I strikes me that the
most likely bugs in this area are bugs of omission, like this and the
missing PARALLEL SAFE recently fixed for functions. Ideally tests
would be able to spot those kinds of issues, but it's not obvious how
to write such tests.

Regards,
Dean

pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: Feature request: make cluster_name GUC useful for psql prompts
Next
From: Kevin Grittner
Date:
Subject: Re: old_snapshot_threshold's interaction with hash index