On Mon, 13 Nov 2023 at 05:29, jian he <jian.universality@gmail.com> wrote:
>
> v13 works fine. all tests passed. The code is very intuitive. played
> with multi WHEN clauses, even with before/after row triggers, work as
> expected.
>
Thanks for the review and testing!
> I don't know when replace_outer_merging will be invoked. even set a
> breakpoint on it. coverage shows replace_outer_merging only called
> once.
>
It's used when MERGING() is used in a subquery in the RETURNING list.
The MergingFunc node in the subquery is replaced by a Param node,
referring to the outer MERGE query, so that the result from MERGING()
is available in the SELECT subquery (under any other circumstances,
you're not allowed to use MERGING() in a SELECT). This is similar to
what happens when a subquery contains an aggregate over columns from
an outer query only -- for example, see:
https://www.postgresql.org/docs/current/sql-expressions.html#SYNTAX-AGGREGATES:~:text=When%20an%20aggregate,aggregate%20belongs%20to.
https://github.com/postgres/postgres/commit/e649796f128bd8702ba5744d36f4e8cb81f0b754
A MERGING() expression in a subquery in the RETURNING list is
analogous, in that it belongs to the outer MERGE query, not the SELECT
subquery.
> sql-merge.html miss mentioned RETURNING need select columns privilege?
> in sql-insert.html, we have:
> "Use of the RETURNING clause requires SELECT privilege on all columns
> mentioned in RETURNING. If you use the query clause to insert rows
> from a query, you of course need to have SELECT privilege on any table
> or column used in the query."
>
Ah, good point. I don't think I looked at the privileges paragraph on
the MERGE page. Currently it says:
You will require the SELECT privilege on the data_source
and any column(s) of the target_table_name referred to in a
condition.
Being pedantic, there are 2 problems with that:
1. It might be taken to imply that you need the SELECT privilege on
every column of the data_source, which isn't the case.
2. It mentions conditions, but not expressions (such as those that can
appear in INSERT and UPDATE actions).
A more accurate statement would be:
You will require the SELECT privilege and any column(s)
of the data_source and target_table_name referred to in any
condition or expression.
which is also consistent with the wording used on the UPDATE manual page.
Done that way, I don't think it would need to be updated to mention
RETURNING, because RETURNING just returns a list of expressions.
Again, that would be consistent with the UPDATE page, which doesn't
mention RETURNING in its discussion of privileges.
> I saw the change in src/sgml/glossary.sgml, So i looked around. in the
> "Materialized view (relation)" part. "It cannot be modified via
> INSERT, UPDATE, or DELETE operations.". Do we need to put "MERGE" into
> that sentence?
> also there is SELECT, INSERT, UPDATE, DELETE, do we need to add a
> MERGE entry in glossary.sgml?
Yes, that makes sense.
Attached is a separate patch with those doc updates, intended to be
applied and back-patched independently of the main RETURNING patch.
Regards,
Dean
