Re: INSERT ... ON CONFLICT DO SELECT [FOR ...] take 2 - Mailing list pgsql-hackers

From Dean Rasheed
Subject Re: INSERT ... ON CONFLICT DO SELECT [FOR ...] take 2
Date
Msg-id CAEZATCV0Xpo4QHkpa66GtA_frfGpaJcK3ua6mSKhb3SQd=xAuQ@mail.gmail.com
Whole thread Raw
In response to Re: INSERT ... ON CONFLICT DO SELECT [FOR ...] take 2  (Andreas Karlsson <andreas@proxel.se>)
List pgsql-hackers
On Mon, 12 May 2025 at 19:33, Andreas Karlsson <andreas@proxel.se> wrote:
>
> I have fixed that one and some other issues locally and will submit a
> new version in a while after I have added more tests because you are
> very correct in that a big issue with my last version of the patch was
> the big lack of tests and lack of making sure all features which
> interact with UPSERT actually worked with my changes. Plus some islation
> tests would be nice to have.
>

+1. Don't forget to move the CF entry to the next open CF.

FYI, over on [1] I proposed more tests and doc updates for RLS. I
think those updates might make it easier to test and document the RLS
aspects of this patch.

[1] https://www.postgresql.org/message-id/flat/CAEZATCWqnfeChjK=n1V_dYZT4rt4mnq+ybf9c0qXDYTVMsy8pg@mail.gmail.com

Regards,
Dean



pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: Conflict detection for update_deleted in logical replication
Next
From: Álvaro Herrera
Date:
Subject: Re: pg_dump misses comments on NOT NULL constraints