Re: [PATCH] Introduce array_shuffle() and array_sample() - Mailing list pgsql-hackers

From Dean Rasheed
Subject Re: [PATCH] Introduce array_shuffle() and array_sample()
Date
Msg-id CAEZATCUzNp-_gype+Z8H7OVuJfEtGCP5T79Aj+31NQRXDvSxpg@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Introduce array_shuffle() and array_sample()  (Martin Kalcher <martin.kalcher@aboutsource.net>)
List pgsql-hackers
On Fri, 22 Jul 2022 at 10:31, Martin Kalcher
<martin.kalcher@aboutsource.net> wrote:
>
> i came to the same conclusions and went with Option 1 (see patch).
> Mainly because most code in utils/adt is organized by type and this way
> it is clear, that this is a thin wrapper around pg_prng.
>
> What do you think?

Looks fairly neat, on a quick read-through. There's certainly
something to be said for preserving the organisation by type.

Regards,
Dean



pgsql-hackers by date:

Previous
From: vignesh C
Date:
Subject: Re: making relfilenodes 56 bits
Next
From: Nikita Malakhov
Date:
Subject: Re: Pluggable toaster