Re: Adding OLD/NEW support to RETURNING - Mailing list pgsql-hackers

From Dean Rasheed
Subject Re: Adding OLD/NEW support to RETURNING
Date
Msg-id CAEZATCUw4PcyKepqHUTef4AJ_OFzP+69QGuHHvdB+kEJDQPhmw@mail.gmail.com
Whole thread Raw
In response to Re: Adding OLD/NEW support to RETURNING  (Dean Rasheed <dean.a.rasheed@gmail.com>)
Responses Re: Adding OLD/NEW support to RETURNING
List pgsql-hackers
On Mon, 25 Mar 2024 at 14:04, Dean Rasheed <dean.a.rasheed@gmail.com> wrote:
>
> v7 patch attached, with those updates.
>

Rebased version attached, forced by 87985cc925.

The changes made in that commit didn't entirely make sense to me, but
the ExecDelete() change, copying data between slots, broke this patch,
because it wasn't setting the slot's tableoid. That copying seemed to
be unnecessary anyway, so I got rid of it, and it works fine. While at
it, I also removed the extra "oldslot" argument added to ExecDelete(),
which didn't seem necessary, and wasn't documented clearly. Those
changes could perhaps be extracted and applied separately.

Regards,
Dean

Attachment

pgsql-hackers by date:

Previous
From: Nathan Bossart
Date:
Subject: Re: Slow GRANT ROLE on PostgreSQL 16 with thousands of ROLEs
Next
From: Tom Lane
Date:
Subject: Re: Slow GRANT ROLE on PostgreSQL 16 with thousands of ROLEs